Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overlays: gpio-shutdown: Add information for Raspberry PI 1 rev 1 #3589

Merged
merged 2 commits into from
May 1, 2020

Conversation

pali
Copy link
Contributor

@pali pali commented Apr 30, 2020

Older Raspberry PI 1 rev 1 uses GPIO1 for power-up instead of GPIO3.

See discussion: #2103 (comment)
CC: @matthijskooijman

KeyboardSignal and kb::kbrequest can be used to call /sbin/shutdown
Copy link
Contributor

@matthijskooijman matthijskooijman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up. Changes look perfect to me.

Copy link
Contributor

@pelwell pelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job on this additional documentation. I have one small request on device naming, but otherwise it looks good.

@@ -874,9 +874,14 @@ Info: Initiates a shutdown when GPIO pin changes. The given GPIO pin
can be powered up again by driving GPIO3 low. The default
configuration uses GPIO3 with a pullup, so if you connect a
button between GPIO3 and GND (pin 5 and 6 on the 40-pin header),
you get a shutdown and power-up button.
you get a shutdown and power-up button. Please note that older
Raspberry PI 1 rev 1 uses GPIO1 instead of GPIO3.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We prefer to write it "Raspberry Pi", but the device in question was the "Model B rev 1" (which is long enough on its own without the "Raspberry Pi" at the start), so please replace all occurrences of "Raspberry PI 1" with "Model B".

@ghost
Copy link

ghost commented May 1, 2020

This wording implies that only older Pi B rev 1 boards use GPIO1, while newer Pi B rev 1 boards use GPIO3. Is that correct, or do all Pi B rev 1 boards use GPIO1? If the latter, please remove 'older' from the description.

@pelwell
Copy link
Contributor

pelwell commented May 1, 2020

I didn't read it that way, but you are right that the word older is at least unnecessary.

@pali
Copy link
Contributor Author

pali commented May 1, 2020

To make it clear, see https://raspberrypi.stackexchange.com/a/87594

Could suggest how to rewrite documentation to be unambiguous?

@pelwell
Copy link
Contributor

pelwell commented May 1, 2020

If you remove every occurrence of the word "older" from your additions it should be clear enough and unambiguous.

…ev 1

Raspberry Pi 1 Model B rev 1 uses GPIO1 for power-up instead of GPIO3.
@pali
Copy link
Contributor Author

pali commented May 1, 2020

Done!

@pelwell
Copy link
Contributor

pelwell commented May 1, 2020

I can live with that.

@pelwell pelwell merged commit dc5e92f into raspberrypi:rpi-4.19.y May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants