-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HVS Core Clock Request Fix #4402
HVS Core Clock Request Fix #4402
Commits on Jun 21, 2021
-
Revert "drm/vc4: Increase the core clock based on HVS load"
This reverts commit 1c38342.
Configuration menu - View commit details
-
Copy full SHA for 00de4b8 - Browse repository at this point
Copy the full SHA 00de4b8View commit details
Commits on Jun 23, 2021
-
Revert "drm: Introduce new state accessors in place of drm_atomic_get…
…_crtc_state" This reverts commit 040d0dd.
Configuration menu - View commit details
-
Copy full SHA for da2c815 - Browse repository at this point
Copy the full SHA da2c815View commit details -
drm/vc4: crtc: Add encoder to vc4_crtc_config_pv prototype
vc4_crtc_config_pv() retrieves the encoder again, even though its only caller, vc4_crtc_atomic_enable(), already did. Pass the encoder pointer as an argument instead of going through all the connectors to retrieve it again. Signed-off-by: Maxime Ripard <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9ffc1fb - Browse repository at this point
Copy the full SHA 9ffc1fbView commit details -
drm/vc4: crtc: Rework the encoder retrieval code (again)
It turns out the encoder retrieval code, in addition to being unnecessarily complicated, has a bug when only the planes and crtcs are affected by a given atomic commit. Indeed, in such a case, either drm_atomic_get_old_connector_state or drm_atomic_get_new_connector_state will return NULL and thus our encoder retrieval code will not match on anything. We can however simplify the code by using drm_for_each_encoder_mask, the drm_crtc_state storing the encoders a given CRTC is connected to directly and without relying on any other state. Signed-off-by: Maxime Ripard <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4a7ec3a - Browse repository at this point
Copy the full SHA 4a7ec3aView commit details -
drm/vc4: crtc: Add some logging
The encoder retrieval code has been a source of bugs and glitches in the past and the crtc <-> encoder association been wrong in a number of different ways. Add some logging to quickly spot issues if they occur. Signed-off-by: Maxime Ripard <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9b8cbbb - Browse repository at this point
Copy the full SHA 9b8cbbbView commit details -
drm/vc4: Leverage the load tracker on the BCM2711
The load tracker was initially designed to report and warn about a load too high for the HVS. To do so, it computes for each plane the impact it's going to have on the HVS, and will warn (if it's enabled) if we go over what the hardware can process. While the limits being used are a bit irrelevant to the BCM2711, the algorithm to compute the HVS load will be one component used in order to compute the core clock rate on the BCM2711. Let's remove the hooks to prevent the load tracker to do its computation, but since we don't have the same limits, don't check them against them, and prevent the debugfs file to enable it from being created. Signed-off-by: Maxime Ripard <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9745251 - Browse repository at this point
Copy the full SHA 9745251View commit details -
drm/vc4: Increase the core clock based on HVS load
Depending on a given HVS output (HVS to PixelValves) and input (planes attached to a channel) load, the HVS needs for the core clock to be raised above its boot time default. Failing to do so will result in a vblank timeout and a stalled display pipeline. Signed-off-by: Maxime Ripard <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 953532f - Browse repository at this point
Copy the full SHA 953532fView commit details