drm/vc4: Add async update support for cursor planes #5141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pelwell
changed the title
|
How does this look to you, @mripard? It has the desired effect in the limited testing I have done (with |
|
For background #4971 introduced the issue with fkms. While the issue only affects fkms users (which is deprecated), its still useful as a debugging test or a workaround for an upstream bug, so I agree this workaround is worthwhile (it fixed the issue in my testing). |
Now that cursors are implemented as regular planes, all cursor movements result in atomic updates. As the firmware-kms driver doesn't support asynchronous updates, these are synchronous, which limits the update rate to the screen refresh rate. Xorg seems unaware of this (or at least of the effect of this), because if the mouse is configured with a higher update rate than the screen then continuous mouse movement results in an increasing backlog of mouse events - cue extreme lag. Add minimal support for asynchronous updates - limited to cursor planes - to eliminate the lag. See: raspberrypi#4971 raspberrypi#4988 Signed-off-by: Phil Elwell <[email protected]>
mripard
reviewed
Aug 24, 2022
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Aug 24, 2022
See: raspberrypi/linux#5141 kernel: rpi-simple-soundcard: limits sample rate of Merus Amp board See: raspberrypi/linux#5144
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Aug 24, 2022
See: raspberrypi/linux#5141 kernel: rpi-simple-soundcard: limits sample rate of Merus Amp board See: raspberrypi/linux#5144
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that cursors are implemented as regular planes, all cursor
movements result in atomic updates. As the firmware-kms driver
doesn't support asynchronous updates, these are synchronous, which
limits the update rate to the screen refresh rate. Xorg seems unaware
of this (or at least of the effect of this), because if the mouse is
configured with a higher update rate than the screen then continuous
mouse movement results in an increasing backlog of mouse events -
cue extreme lag.
Add minimal support for asynchronous updates - limited to cursor
planes - to eliminate the lag.
Signed-off-by: Phil Elwell [email protected]