-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PICO_EXTRAS_FETCH_FROM_GIT does not work #24
Comments
Observations: This happens because The virtually identical code for fetching pico sdk works as expected. The variable Also note that this isn't because I didn't download the SDK first. Adding the include for it causes it to download 2.2GB of data, and then fail on the extras in the exact same way. I left that step out because downloading 2.2GB is slow and unnecessary to reproduce the problem. |
This brings the code in-line with what is done in the Pico SDK and seems to be required in order for pico_extras_SOURCE_PATH to be set. Fixes raspberrypi#24
This fixes raspberrypi/pico-extras#24 so that PICO_EXTRAS_FETCH_FROM_GIT works. A PR is pending.
This fixes raspberrypi/pico-extras#24 so that PICO_EXTRAS_FETCH_FROM_GIT works.
This brings the code in-line with what is done in the Pico SDK and seems to be required in order for pico_extras_SOURCE_PATH to be set. Fixes #24 Co-authored-by: Graham Sanderson <[email protected]>
Steps to reproduce:
pico_extras_import.cmake
in it.CMakeLists.txt
with the following contents:cmake -DPICO_EXTRAS_FETCH_FROM_GIT=1 ..
Expected result:
The pico extras repository should be downloaded and added as a subdirectory of the current project.
Actual result:
The pico extras repository is downloaded and then
${CMAKE_BINARY_DIR}
is added as a subdirectory. This directory contains noCMakeLists.txt
so cmake errors out, and the project cannot be built.The text was updated successfully, but these errors were encountered: