Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEBUG messages are printed by CMake versions < 3.15 #422

Closed
jonathangjertsen opened this issue May 19, 2021 · 0 comments
Closed

DEBUG messages are printed by CMake versions < 3.15 #422

jonathangjertsen opened this issue May 19, 2021 · 0 comments

Comments

@jonathangjertsen
Copy link
Contributor

The minimum CMake version is 3.13, but the DEBUG level for message() was added in CMake 3.15 - with earlier versions, the message is simply concatenated with DEBUG resulting in output like:

DEBUGPICO_GCC_TRIPLE defaulted to arm-none-eabi
...
DEBUGIncluding custom CMake file [redacted]/pico-sdk/src/common/pico_base/generate_config_header.cmake
DEBUGELF2UF2 will need to be built

(from PR #365)
jonathangjertsen added a commit to jonathangjertsen/pico-sdk that referenced this issue May 22, 2021
@jonathangjertsen
Prevent the literal string DEBUG from being appended to some messages…
815f4c4 
… in CMake < 3.15

Fixes issue raspberrypi#422
jonathangjertsen added a commit to jonathangjertsen/pico-sdk that referenced this issue May 22, 2021
@jonathangjertsen
Prevent the literal string DEBUG from being appended to some messages…
e92b3a4 
… in CMake < 3.15

Fixes issue raspberrypi#422
@jonathangjertsen jonathangjertsen mentioned this issue May 22, 2021
Merged
jonathangjertsen added a commit to jonathangjertsen/pico-sdk that referenced this issue May 25, 2021
@jonathangjertsen
Prevent the literal string DEBUG from being appended to some messages…
bdf76b5 
… in CMake < 3.15

Fixes issue raspberrypi#422
kilograham pushed a commit that referenced this issue May 25, 2021
@jonathangjertsen
Prevent the literal string DEBUG from being appended to some messages…
a531123 
… in CMake < 3.15 (#433)

Fixes issue #422
@v9938 v9938 mentioned this issue Jun 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jonathangjertsen