Fix loading of PICO_TOOLCHAIN_PATH #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
josesimoes
commented
Mar 16, 2021
•
josesimoes
commented
- Add double quotes because build option it's a string.
- Remove comment as requested by @kilograham.
- Resolves Build option PICO_TOOLCHAIN_PATH has no effect #258.
|
Nice 👍 Apologies if any of my uninformed comments threw you off the scent! 👃 |
kilograham
requested changes
Mar 17, 2021
cmake/pico_pre_load_toolchain.cmake
Outdated
| @@ -1,6 +1,6 @@ | |||
| # PICO_CMAKE_CONFIG: PICO_TOOLCHAIN_PATH, Path to search for compiler, default=none (i.e. search system paths), group=build | |||
| # Set your compiler path here if it's not in the PATH environment variable. | |||
| set(PICO_TOOLCHAIN_PATH "" CACHE INTERNAL "") | |||
| # Set your compiler path here with PICO_TOOLCHAIN_PATH CMake option, if it's not in the PATH environment variable. | |||
There was a problem hiding this comment.
I'd remove this comment completely - the PICO_CMAKE_CONFIG comment explains what the var is for.
|
sorry, can you please rebase this onto develop-1.1.1 (it'll get released sooner that way) - still working thru the best branching policy! |
- Add double quotes because build option it's a string. - Remove comment as requested by @kilograham. - Resolves raspberrypi#258.
|
@kilograham I've started started over from develop1.1.1 and changed the base as develop1.1.1. |
kilograham
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.