-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Color dot problem #19
Comments
The corruption looks to match the saturated bits of the image quite well. This probably rules out anything to do with the CSI-2 link (i.e. cable, clocking, etc.). As a guess, I would say colour denoise might be causing this, as qcam disables colour denoise by default. Some further questions:
|
Hi @naushir thanks for the reply,
I have this problem almost every time I run libcamera-hello/vid/still.
libcamera-still/vid/hello -t 0
I tried several times, but the image saved by still has no problem (because the color dots have been flashing, I'm not sure if I got a good frame), but the h264 file saved by vid has this problem.
This problem disappeared after adding the --denoise=cdn_off parameter. |
Thanks for confirming. This does sound like video CDN causing this corruption. Unfortunately, I did not manage to reproduce this yet for myself, will keep trying. @davidplowman, are you able to see this corruption on your setup? |
@glddiv if you point the camera at a dark scene, without any bright lights or windows to saturate the image, do you still see the corruption? |
No, I'm not seeing it but will keep an eye open. |
Hi @naushir, |
@glddiv thank you for trying that out. So it does not seem to be specific to saturated bits in the image. I will need to look at the code in a bit more detail.... |
I'm really struggling with this one. I cannot reproduce it, and nothing in the code seems wrong as far as I can tell. @glddiv, to rule out hardware problems, can you do the following (if possible):
|
Hi @naushir I tried IMX219 and IMX477, no luck. Today I tried to update everything to the latest, and now the program cannot run. |
Things going from bad to worse :-( I did just try a full rebuild and update of kernel and firmware and I do not see the same problem. Here is my version strings:
Any chance you might have another Raspberry Pi board to try this on? |
Just to clarify, the update I did was a custom build on ToT for linux and firmware. I have subsequently done a rpi-update, and it now matches exactly with your versions:
Everything still works fine for me. @davidplowman, are you able to do an update on your device and see if you get any errors? |
I've just been round the "install fresh image, follow all those instructions" loop with my Pi4 and imx219, and it works with no problems. So this is definitely proving very puzzling. I shall continue to look out for the "dots", however... |
Hi @naushir |
Things have become even more weird. It seems to have the same problem when connecting to WIFI. I recorded a simple video to show this phenomenon. https://drive.google.com/file/d/1YyGSmgeqwu5lObZBVF4lhFM-o57lf9W6/view?usp=sharing |
@glddiv thanks for the update. I'm using wifi in my setup at home, but I have also tried with an Ethernet cable and still no luck reproducing. If it's an electrical issue, it does seem strange that switching off colour denosie seems to solve it, I can't really explain that.... Will continue to try and reproduce. |
@naushir |
@glddiv, thank you for your help debugging this. I will continue looking at this in the background. If you have any updates, please do post them here. |
See: raspberrypi/linux#4303 kernel: HDMI support for modes that require the scrambler (4k @ 60Hz, most importantly) See: raspberrypi/linux#4302 kernel: overlays: spi-rtc: Add ds3232 and ds3234 See: raspberrypi/linux#4292 firmware: isp: Ensure the VRF is locked when setting up video colour denoise See: raspberrypi/rpicam-apps#19 firmware: isp: Remove custom EV mappings from camera tunings firmware: Add support for board-type=0xXX conditional filters in bootloader, bootcode and firmware firmware: Two UART1 patches See: #1566
See: raspberrypi/linux#4303 kernel: HDMI support for modes that require the scrambler (4k @ 60Hz, most importantly) See: raspberrypi/linux#4302 kernel: overlays: spi-rtc: Add ds3232 and ds3234 See: raspberrypi/linux#4292 firmware: isp: Ensure the VRF is locked when setting up video colour denoise See: raspberrypi/rpicam-apps#19 firmware: isp: Remove custom EV mappings from camera tunings firmware: Add support for board-type=0xXX conditional filters in bootloader, bootcode and firmware firmware: Two UART1 patches See: raspberrypi/firmware#1566
A fix has been pushed to the latest rpi-update firmware. |
@glddiv the fix in rpi-update might just solve your colour dots problem. It's hard to tell, as I cannot reproduce the original fault, but I did fix a problem in the colour denoise code that could cause pixel corruption in the right circumstances. If you do get a chance to try it out, please let us know the results. |
Hi @popcornmix , @naushir Thank you. |
- firmware: isp: Fix handling of different YUV colour spaces - firmware: poe_hat: Actually close the I2C handle - firmware: platform: Define DVFS modes and change default to be fixed AVS voltage - firmware: arm_loader: Auto-select 64-bit for kernel8.img See: #1193 - firmware: hdmi: Throttle auto-i2c register writes to avoid PWM audio underrun - firmware: platform: Define DVFS modes and change default to be fixed AVS voltage - firmware: arm_loader: Auto-select 64-bit for kernel8.img See: #1193 - firmware: hdmi: Throttle auto-i2c register writes to avoid PWM audio underrun - firmware: video_decode lockup handling - firmware: isp: Initialise extras to avoid vpitch being random - firmware: usb: Fix dropouts with USB ethernet gadget See: raspberrypi/linux#4084 - firmware: imx477: Allow long exposures for the binned modes. See: https://www.raspberrypi.org/forums/viewtopic.php?f=43&t=297521 - firmware: arm_dispmanx: Use ALPHA_MIX flag See: https://www.raspberrypi.org/forums/viewtopic.php?t=300769 - firmware: power: Refactor the interface to the PMICs - firmware: platform: vl805: Get BAR2 address from PCIe BAR2 registers - firmware: arm_loader: Return all borrowed DMA channels See: #1541 - firmware: hdmi_2711: Rework I2C driver to NOT use the AUTO-I2C block - firmware: gencmd: Allow groups of clocks/plls to be read together - firmware: power: Fix DA9090 under-voltage detection - firmware: NVME boot support - firmware: brfs: Fix USB bulk-read in start.elf See: Hexxeh/rpi-firmware#258 - firmware: hdmi_2711_i2c: Correct handling of start/stop codes for long read See: #1548 - firmware: video_decode: For VC1/WMV with no signalled header bytes, use start of 1st buffer See: raspberrypi/linux#4113 - firmware: vl805: Remove redundant log statement and fix warning - firmware: power: Fix DA9090 ADC1 register definition - firmware: arm_loader: Only report clocks arm has set, not siblings - firmware: arm_loader: Don't report clocks set as turbo side effect of arm clock - firmware: arm_loader: 2711: gpu clocks are not dependant - firmware: platform: Need to clear cached versions of get_max_clock_internal vars - firmware: Move core to PLLA and support accurate clk108 See: xbmc/xbmc#19263 - firmware: board_info: Separate memory size from OTP field encoding - firmware: power: Swap DA9090 ADC assignments to match XR77004 - firmware: board-info: Fix memsize on 3B+ - firmware: vcfw/power: Add a new latch for power_pad_control See: #1552 - firmware: arm_loader: kernel_old=1 should force kernel_address=0 See: #1561 - firmware: scalerlib: Fix offset applied to x coordinate of YUV10COL image See: https://forum.kodi.tv/showthread.php?tid=361164&pid=3024654#pid3024654 - firmware: isp: Ensure the VRF is locked when setting up video colour denoise See: raspberrypi/rpicam-apps#19 - firmware: isp: Remove custom EV mappings from camera tunings - firmware: Add support for board-type=0xXX conditional filters in bootloader, bootcode and firmware - firmware: Two UART1 patches See: #1566 - firmware: Pi400: Reduce MII clock freq when probing ethernet PHY - firmware: platform: Remove build-time constant for MICROVOLTS_PER_PIP - firmware: dt-blob.dts: Correct HDMI HPD and EMMC_ENABLE for CM4 See: https://www.raspberrypi.org/forums/viewtopic.php?f=29&p=1858516 - firmware: vcfw/hdmi: CUSTOM modes used for FKMS didn't set RGB quant range correctly See: #1580 - firmware: PoE+ HAT support See: raspberrypi/linux#4367 - firmware: arm_loader: Use Pi4 bootloader MAC_ADDRESS if set - firmware: platform: Apply ARM thermal throttling rules on BCM2711 - firmware: bcm_host: Recognise all Pi 4 variants, add BCM2711 See: raspberrypi/userland#695 - firmware: video_decode: Use the ISP instead of vc_image_convert - firmware: hdmi-2711: Wait for HDMI hardware scheduler to activate in HDMI mode - arm_loader: Add message to release firmware framebuffer - firmware: arm_loader: Add rng-seed DT property See: #1595 - firmware: isp: Set the YUV420/YVU420 format stride to 64 byte - firmware: Revert: video_decode: Use the ISP instead of vc_image_convert - firmware: cec: Avoid sending messages with kms See: raspberrypi/linux#4460 - firmware: hdmi_cec: Remove TX/RX SW_INIT on power_on See: Hexxeh/rpi-firmware#267 See: https://www.raspberrypi.org/forums/viewtopic.php?p=1895082#p1895082 - firmware: arm_dt: Limit CMA to 256MB if total_mem < 2GB or gpu_mem > 256MB See: #1603 - firmware: video_decode: Use the ISP instead of vc_image_convert - firmware: video_decode: Correct support for YVU formats using ISP - firmware: firmware: Disable VLL loading from file system See: #1605 - firmware: arm_loader: Make most arm clock requests required See: #1598 - firmware: arm_loader: Consider required flags from GET_CLOCK_RATE See: #1598 - firmware: arm_dt: Load overlays for detected cameras - firmware: Make more use of the user-warnings DT property - firmware: hdmi_2711: Use HDMI block REPEAT_PIXEL instead of PV See: https://forum.libreelec.tv/thread/24415-le-10-beta-for-i4-force-hdmi-resolution - firmware: DSI display autodetection for kms - firmware: arm_loader: Allow hvs interrupt during SET_NOTIFY_DISPLAY_DONE - firmware: arm_display: Allow null buffer in successful call See: raspberrypi/linux#4540 - firmware: video_decode: Ensure all buffers are flushed before port disable completes - firmware: filesystem: sdcard: Fix Hybrid GPT partitions See: #1465 - firmware: tvservice: Add check to warn when running with kms - firmware: arm_loader: Allow non-optional reads of current clock See: #1619 - firmware: dispmanx: Demote null eptr from vcos_verify to no warning See: raspberrypi/linux#4592 - firmware: filesystem: sdcard: Probe FAT type in GPT ESD partitions - firmware: clock-2711: Limit PLLB VCO frequency to the high range - firmware: arm_dt: Export the boot-mode, partition and usb state via device-tree See: #1621 - firmware: video_decode: i/p port enable/disable without o/p active could stall See: RPi-Distro/vlc#48 See: Hexxeh/rpi-firmware#272 See: #1637 - firmware: userland: Reduce debug_sym error messages See: https://forums.raspberrypi.com/viewtopic.php?f=98&t=322238 - firmware: arm_dt: Increase maximum line length to 98 See: raspberrypi/linux#4638 - firmware: arm_loader: Allow VEC clock to be controlled by arm - firmware: platform: Remove licence on VP6, VP8, Theora, and FLAC See: raspberrypi/linux#4661 - firmware: ISP: Fix magenta colour in right hand image of stereo pair See: https://forums.raspberrypi.com/viewtopic.php?t=321089 - firmware: platform: Fix incorrect turbo voltage scaling on Pi0 See: raspberrypi/documentation#2255 - firmware: platform: Declare CM4's SIO_1V8_SEL and SD_PWR_ON See: raspberrypi/Raspberry-Pi-OS-64bit#188 - firmware: hello_fft: Update outdated link to V3D spec - firmware: hello_fft: Remove unused function declaration See: #1645 See: raspberrypi/userland#710 - firmware: dtoverlay: Rebase aliases in overlays like labels - firmware: isp: Set core/vpu min clock to 320Mhz during ISP operation - firmware: arm_loader: Enable watchdog early if wanted See: #1651 - firmware: board_info: Add upstream dtb names for cm1 & 3 - firmware: board_info: Add upstream dtb name for cm4 See: #1660 - firmware: platform: Allow users to disable camera boot HMAC check See: #1657 - firmware: clock: 2711: Fix potential API issue in 2711 VCO setup - firmware: arm_loader: Enable USB MSD boot mode on Zero 2 W - firmware: isp: Fix Rec.709 colour space problems
Hi there,
When I was using libcamera-app, there was a strange color dot problem, but when I switched to qcam, there was no problem.
What could be the cause of this?
raspberry pi:
P4B 8GB
camera:
imx219
system version:
Linux raspberrypi 5.10.17-v7l+ #1 SMP Thu Mar 18 16:45:46 CST 2021 armv7l GNU/Linux
The text was updated successfully, but these errors were encountered: