Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the libcamera_apps class implementation into its own cpp file. #47

Merged
merged 6 commits into from
Jul 6, 2021
Merged

Move the libcamera_apps class implementation into its own cpp file. #47

merged 6 commits into from
Jul 6, 2021

Commits on Jul 6, 2021

  1. libcamera_app: Make Options a base class ptr in class LibcameraApp 

    Instead of a template parameter, store an Options base class pointer in the
LibcameraApp class. This allows us to separate out the class implementation in
a separate cpp file in a subsequent change.
    @naushir
    naushir committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    5949cd2 View commit details
    Browse the repository at this point in the history

  2. libcamera_app: Add libcamera_app.cpp as the implementation of class L… 

    …ibcameraApp

This gives us quicker compilations for all the libcamera apps.
    @naushir
    naushir committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    9b8fafc View commit details
    Browse the repository at this point in the history

  3. libcamera_app: Switch to use a unique_ptr for Options in the Libcamer… 

    …aApp class.

This minor change allows the Options object to fully live within the class and
not have the application worry about lifetime management.
    @naushir
    naushir committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    b9b5f24 View commit details
    Browse the repository at this point in the history

  4. libcamera_apps: Make the options struct protected in the LibcameraApp… 

    … class

Add a GetOption() method to retrieve the options struct from the application.
This can be overridden if an app derives from LibcameraApp and uses a derived
options struct.
    @naushir
    naushir committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    07ca632 View commit details
    Browse the repository at this point in the history

  5. tests: Increase libcamera_raw and libcamera_still:timelapse test time… 

    …out.

My sdcard write speed would sometime cause these capture tests to timeout.
    @naushir
    naushir committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    8566ac9 View commit details
    Browse the repository at this point in the history

  6. Clean up warnings when the camera is stopped 

    Previously other threads might be trying to queue new requests while
the camera is being stopped. This could produce warnings if
queueRequest fails. Now the two procedures are protected from one
another with the camera_stop_mutex_.

Signed-off-by: David Plowman <[email protected]>
    @davidplowman @naushir
    davidplowman authored and naushir committed Jul 6, 2021
    Configuration menu
    Copy the full SHA
    61055d1 View commit details
    Browse the repository at this point in the history