Tf stage #71
Merged
Tf stage #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidplowman
force-pushed
the
tf-stage
branch
from
90c481c
to
8e62ba0
Compare
naushir
reviewed
Sep 1, 2021
| model_ = tflite::FlatBufferModel::BuildFromFile(config_->model_file.c_str()); | ||
| std::cout << "TfStage: Loaded model " << config_->model_file << std::endl; | ||
| model_->error_reporter(); | ||
|
|
There was a problem hiding this comment.
If there is an error (e.g. model file missing), do we need some kind of exception here?
There was a problem hiding this comment.
Yes, I'll fix that.
… stages The TfStage class provides a certain amount of TFLite boilerplate, and handles various tasks like fetching the streams, cropping the image to the right size, and so on. It also calls the interpreter asynchronously and provides an API for derived classes to implement to interpret and use the results. Signed-off-by: David Plowman <[email protected]>
…lass Mostly the effect is just to remove code which is now provided in the TfStage base class. Signed-off-by: David Plowman <[email protected]>
…lass Mostly this just involves the removal of code that is now in the base class. Signed-off-by: David Plowman <[email protected]>
…ion_tf.json This is the name it should have to match everything else. Signed-off-by: David Plowman <[email protected]>
davidplowman
force-pushed
the
tf-stage
branch
from
8e62ba0
to
fe190e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@naushir
This set of patches adds the new TfStage base class which makes the addition of new TFLite-based post-processing stages easier. The first of the commits adds the new TfStage class implementation.
Subsequently there's one patch that refactors the Object Classifier to use the new base class, and another that further refactors the Pose Estimator in the same way. (There's a final small file renaming patch that just fixes up an incorrect JSON file name.,)