rpicam-vid: Update for camera sync algorithm #727
+32
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@naushir Another one! |
naushir
reviewed
Oct 3, 2024
A "sync" option has been added, which may take the values "server" or "client", turning the camera into either the server of client of a synchronised recording. Setting the camera into sync mode, and skipping frames while waiting for sync, is delegated to the RPiCamEncoder class, so that all video recording applications acquire the functionality. Signed-off-by: David Plowman <[email protected]> Signed-off-by: Arsen Mikovic <[email protected]> Signed-off-by: Naushir Patuck <[email protected]>
naushir
reviewed
Oct 3, 2024
| @@ -158,6 +158,8 @@ struct VideoOptions : public Options | |||
| ("av-sync", value<std::string>(&av_sync_)->default_value("0us"), | |||
| "Add a time offset (in microseconds if no units provided) to the audio stream, relative to the video stream. " | |||
| "The offset value can be either positive or negative.") | |||
| ("sync", value<std::string>(&sync_)->default_value("off"), | |||
| "Whether to synchronise with another camera. Use \"off\", \"server\" or \"client\".") | |||
There was a problem hiding this comment.
Outside the #if block as well... sorry I missed this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A "sync" option has been added, which may take the values "server" or "client", turning the camera into either the server of client of a synchronised recording.
Recording only starts once the sync algorithm flag that the cameras are "ready to go".