Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buffer handling PNG encoding is causing an error #78

Closed
alexamy1987 opened this issue Aug 30, 2013 · 7 comments
Closed

buffer handling PNG encoding is causing an error #78

alexamy1987 opened this issue Aug 30, 2013 · 7 comments
Assignees
@JamesH65

Comments

@alexamy1987
Copy link

buffer handling PNG encoding is causing an error which produces a bright band at the top of the image.
EDIT: This occurs not only on green light as first expected.
550nm
@popcornmix
Copy link
Contributor

Do you have simple test code that triggers the problem?

@alexamy1987
Copy link
Author

I just typed the raspistill commands directly into the terminal to capture these images

Here the same image but jpeg format:

'raspistill -awb off -ex off -o 550nm.jpg'

550nm

@ghost ghost assigned JamesH65 Aug 30, 2013
@popcornmix
Copy link
Contributor

Mentioning it is running raspistill is useful information. Assigning to @JamesH65

@Ruffio
Copy link

Ruffio commented Jun 26, 2015

@JamesH65 any progress on this issue?

@6by9
Copy link
Contributor

6by9 commented Jan 1, 2016

Wow, an oldie.

This will actually be a firmware issue but exposed by raspistill.
At a guess, when the YUV to RGB conversion required for PNG is done it is probably picking up a different colourspace for the first vs subsequent stripes. I'll try to have a look - James no longer has firmware access.

popcornmix added a commit to raspberrypi/firmware that referenced this issue Apr 8, 2016
@popcornmix
pwm_sdm: fix ring buffer UINT_MAX wraparound bug
e968a4e 
See: https://www.raspberrypi.org/forums/viewtopic.php?f=29&t=136445

firmware: IL ISP: Correct RGB to YUV matrices, and ignore code side info

firmware: MJPEG encode: Handle stereoscopic images
See: https://www.raspberrypi.org/forums/viewtopic.php?f=43&t=138325&p=918041

firmware: IL Camera: Change unspecified colour space to being JFIF
See: raspberrypi/userland#78

firmware: OV5647: Option to configure auto lens shading to use potential fix

firmware: arm_loader: Factor out DT support into arm_dt
See: raspberrypi/linux#1394

firmware: arm_ldconfig: Switch to using arm stubs generated from tools/mkimage
firmware: arm_ldconfig: Support loading arm stubs from file
See: #579
popcornmix added a commit to Hexxeh/rpi-firmware that referenced this issue Apr 8, 2016
@popcornmix
pwm_sdm: fix ring buffer UINT_MAX wraparound bug
4bc6b67 
See: https://www.raspberrypi.org/forums/viewtopic.php?f=29&t=136445

firmware: IL ISP: Correct RGB to YUV matrices, and ignore code side info

firmware: MJPEG encode: Handle stereoscopic images
See: https://www.raspberrypi.org/forums/viewtopic.php?f=43&t=138325&p=918041

firmware: IL Camera: Change unspecified colour space to being JFIF
See: raspberrypi/userland#78

firmware: OV5647: Option to configure auto lens shading to use potential fix

firmware: arm_loader: Factor out DT support into arm_dt
See: raspberrypi/linux#1394

firmware: arm_ldconfig: Switch to using arm stubs generated from tools/mkimage
firmware: arm_ldconfig: Support loading arm stubs from file
See: raspberrypi/firmware#579
@popcornmix
Copy link
Contributor

Latest rpi-update firmware has a potential fix for this issue

XECDesign pushed a commit to RPi-Distro/firmware that referenced this issue May 4, 2016
@popcornmix @XECDesign
pwm_sdm: fix ring buffer UINT_MAX wraparound bug
b062323 
See: https://www.raspberrypi.org/forums/viewtopic.php?f=29&t=136445

firmware: IL ISP: Correct RGB to YUV matrices, and ignore code side info

firmware: MJPEG encode: Handle stereoscopic images
See: https://www.raspberrypi.org/forums/viewtopic.php?f=43&t=138325&p=918041

firmware: IL Camera: Change unspecified colour space to being JFIF
See: raspberrypi/userland#78

firmware: OV5647: Option to configure auto lens shading to use potential fix

firmware: arm_loader: Factor out DT support into arm_dt
See: raspberrypi/linux#1394

firmware: arm_ldconfig: Switch to using arm stubs generated from tools/mkimage
firmware: arm_ldconfig: Support loading arm stubs from file
See: raspberrypi#579
@popcornmix
Copy link
Contributor

I believe this is resolved. Please reopen if it is not.

neuschaefer pushed a commit to neuschaefer/raspi-binary-firmware that referenced this issue Feb 27, 2017
@popcornmix
pwm_sdm: fix ring buffer UINT_MAX wraparound bug
764b4bd 
See: https://www.raspberrypi.org/forums/viewtopic.php?f=29&t=136445

firmware: IL ISP: Correct RGB to YUV matrices, and ignore code side info

firmware: MJPEG encode: Handle stereoscopic images
See: https://www.raspberrypi.org/forums/viewtopic.php?f=43&t=138325&p=918041

firmware: IL Camera: Change unspecified colour space to being JFIF
See: raspberrypi/userland#78

firmware: OV5647: Option to configure auto lens shading to use potential fix

firmware: arm_loader: Factor out DT support into arm_dt
See: raspberrypi/linux#1394

firmware: arm_ldconfig: Switch to using arm stubs generated from tools/mkimage
firmware: arm_ldconfig: Support loading arm stubs from file
See: raspberrypi#579
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JamesH65 JamesH65

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@popcornmix @Ruffio @JamesH65 @alexamy1987 @6by9