bcm_host: Recognise all Pi 4 variants, add BCM2711 #696
Conversation
bcm_host_is_model_pi4 should be equivalent to a test that the processor type is BCM2711, so implement it as such (having added BCM2711 as a recognised processor type and deprecating the name BCM2838). See: raspberrypi#695 Signed-off-by: Phil Elwell <[email protected]>
|
LGTM unless we want to make the distinction between pi4 and bcm2711. I'm not sure of my view on that one seeing as the user can just as easily check the model number directly without a function. @jc-kynesim was asking about this the other day as it meant one of his checks in either VLC or Chromium failed on Pi400. |
|
I don't really understand why this function exists, but the few uses I can find are essentially checks of the SoC capabilities, hence this change. I certainly don't think we should add any more "helpers". |
|
I think I was the one that asked for this, as you say, for a capability check so I could look for the right decode h/w with the expectation that "pi4" would cover all variants that were essentially the same and I didn't have to update my code as the system changed. |
|
Ha - I've just found an internal Merge Request from @popcornmix that appeared while I was on holiday doing exactly the same thing. I think that counts as consent. |
|
Thanks guys! I am new to this ... but glad that the issue of detecting pi4 family is being addressed. |
bcm_host_is_model_pi4 should be equivalent to a test that the processor
type is BCM2711, so implement it as such (having added BCM2711 as a
recognised processor type and deprecating the name BCM2838).
See: #695
Signed-off-by: Phil Elwell [email protected]