Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail on name provided with options #133

Closed
silkentrance opened this issue Jul 4, 2017 · 3 comments · Fixed by #135 or Urigo/tortilla#58
Closed

Tests fail on name provided with options #133

silkentrance opened this issue Jul 4, 2017 · 3 comments · Fixed by #135 or Urigo/tortilla#58

Comments

@silkentrance
Copy link
Collaborator

silkentrance commented Jul 4, 2017

If one provides a name via the options, then existing tests will fail. This is due to the fact that the provided name circumvents the random name generation.

Tests must be fixed so that when using custom provided names, these files or directories will be cleaned up after each test run.

The failing tests are test/dir-sync-test.js and test/file-sync-test.js with the names having already been taken by test/dir-test.js and test/file-test.js.

silkentrance added a commit that referenced this issue Jul 4, 2017
silkentrance added a commit that referenced this issue Jul 4, 2017
silkentrance added a commit that referenced this issue Jul 4, 2017
silkentrance added a commit that referenced this issue Jul 10, 2017
revert changes from #133
silkentrance added a commit that referenced this issue Jul 10, 2017
fix #134
revert changes to tests introduced by #133
@silkentrance
Copy link
Collaborator Author

Must reopen as the provided fix did not work.

@silkentrance silkentrance reopened this Jul 10, 2017
silkentrance added a commit that referenced this issue Jul 10, 2017
@silkentrance
Copy link
Collaborator Author

After having looked into this further, it shows that dir-test and dir-sync-test are competing for the same resource (using name test). The order by which these test suites/batches are run is important, as dir-test will not call upon the remove callback.

@silkentrance silkentrance mentioned this issue Jul 10, 2017
@silkentrance
Copy link
Collaborator Author

fixed with #137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant