fix: avoid relying on Node’s internals #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`process.binding()` is an internal API of Node, and its use should be avoided. Modern versions of Node have `constants` properties on the individual public modules, so using these and falling back to the `process.binding()` path ensures that this module is unaffected by changes to Node’s internals.
addaleax
commented
Jan 27, 2018
| @@ -289,7 +292,7 @@ function fileSync(options) { | |||
| var fd = fs.openSync(name, CREATE_FLAGS, opts.mode || FILE_MODE); | |||
| /* istanbul ignore else */ | |||
| if (opts.discardDescriptor) { | |||
| fs.closeSync(fd); | |||
| fs.closeSync(fd); | |||
There was a problem hiding this comment.
This is an editor-generated change, let me know if you want me to remove it from this patch
raszi
approved these changes
Jan 28, 2018
| @@ -289,7 +292,7 @@ function fileSync(options) { | |||
| var fd = fs.openSync(name, CREATE_FLAGS, opts.mode || FILE_MODE); | |||
| /* istanbul ignore else */ | |||
| if (opts.discardDescriptor) { | |||
| fs.closeSync(fd); | |||
| fs.closeSync(fd); | |||
raszi
changed the title
This was referenced Mar 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
process.binding()is an internal API of Node, andits use should be avoided.
Modern versions of Node have
constantspropertieson the individual public modules, so using these
and falling back to the
process.binding()pathensures that this module is unaffected by
changes to Node’s internals.