Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove const declaration in bn-to-num #4

Merged
merged 1 commit into from
Mar 30, 2017
Merged

Remove const declaration in bn-to-num #4

merged 1 commit into from
Mar 30, 2017

Conversation

jth-
Copy link
Contributor

@jth- jth- commented Mar 28, 2017

Remove const declaration in favor of a var so as not to throw an error in older webkit browsers.

https://bugs.webkit.org/show_bug.cgi?id=161464

@mikolalysenko mikolalysenko merged commit ff5ada2 into rat-nest:master Mar 30, 2017
@mikolalysenko
Copy link
Member

Sorry about that, wasn't paying attention

@ashnur
Copy link
Contributor

ashnur commented Mar 31, 2017

Interesting lesson for me that this turned out to be a problem.

@etpinard etpinard mentioned this pull request Mar 31, 2017
Merged
@rreusser
Copy link

FWIW we added an eslint pass with ecmaVersion: 5 and no other rules. Quick n easy way to assert ES5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jth- @mikolalysenko @ashnur @rreusser