Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handle re-adding devices #15

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Better handle re-adding devices #15

merged 1 commit into from
Mar 20, 2024

Conversation

8none1
Copy link
Collaborator

@8none1 8none1 commented Mar 17, 2024

Fixes: #14

How to test

Before testing this branch recreate the problem

  • Delete a working device
  • From the LEDnetWF page click "Add Device"
    image
  • Click through and you should get an error

After installing this branch

  • You should now be able to click "Add device" and the process should complete without an error

@8none1 8none1 requested a review from raulgbcr March 17, 2024 20:44
@8none1 8none1 mentioned this pull request Mar 17, 2024
Closed
raulgbcr
raulgbcr approved these changes Mar 20, 2024
View reviewed changes
Copy link
Owner

@raulgbcr raulgbcr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working for me, thanks for the fix!!

@8none1 8none1 merged commit 03ebc27 into main Mar 20, 2024
4 checks passed
@8none1 8none1 deleted the 8none1/issue14 branch March 20, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulgbcr raulgbcr raulgbcr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding devices from the config screen results in error KeyError: 'title_placeholders'
2 participants
@8none1 @raulgbcr