RDoc-2699 [Node.js] Document extensions > Attachments > Bulk insert [Replace C# samples]

[Danielle9897]

Related issue:
https://issues.hibernatingrhinos.com/issue/RDoc-2699/Node.js-Document-extensions-Attachments-Bulk-insert-Replace-C-samples

---

Node.js: @ml054

• Node.js files to review:

Documentation/5.4/Raven.Documentation.Pages/document-extensions/attachments/bulk-insert.js.markdown
Documentation/5.4/Samples/nodejs/documentExtensions/attachments/bulkInsert.js

C#:

• Files were copied over to v5.4 and organized

[ml054]

Im not sure if saying Persist is equivalent of calling finish, as it might suggest it is persistent in single shot.

It is rather saying to the server: I've finished, flush data, save it and return once completed.

[Danielle9897]

I updated comments - hope it's better like this:
Added: // The data stored in bulkInsert will be streamed to the server in batches
Modified: // Call finish to send all remaining data to the server

try {
            for (let i = 0; i < users.length; i++) {

                // Call `attachmentsFor`, pass the document ID for which to attach the file
                const attachmentsBulkInsert = bulkInsert.attachmentsFor(users[i].id);
                
                // Call 'store' to attach the byte array to the bulkInsert instance
                // The data stored in bulkInsert will be streamed to the server in batches 
                await attachmentsBulkInsert.store("attachmentName", byteArray);
            }
        } finally {
            // Call finish to send all remaining data to the server
            await bulkInsert.finish();
        }

I will update the Node.js README as well..
See pr: ravendb/ravendb-nodejs-client#416