Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDoc-2948 & RDoc-2949 Cloud Cluster Health documentation #1909

Merged
merged 3 commits into from
Sep 30, 2024

Conversation

@PFYasu PFYasu self-assigned this Sep 19, 2024
@PFYasu PFYasu added the Cloud label Sep 19, 2024
@PFYasu PFYasu marked this pull request as draft September 19, 2024 09:59
@PFYasu PFYasu force-pushed the RDoc-2949 branch 2 times, most recently from 7fe4f05 to a6f52e3 Compare September 20, 2024 06:32
@PFYasu PFYasu marked this pull request as ready for review September 20, 2024 06:35

Suggestions are generated based on a 60-day period divided in half.

**First period** (hereinafter referred to as **previous period**) lasts from *-60* to *-30* days from now.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**First period** (hereinafter referred to as **previous period**) lasts from *-60* to *-30* days from now.
**First period** (hereinafter referred to as **previous period**) lasts from *now - 60 days* to *now - 30 days.*

Suggestions are generated based on a 60-day period divided in half.

**First period** (hereinafter referred to as **previous period**) lasts from *-60* to *-30* days from now.
**Second period** (hereinafter referred to as **current period**) lasts from *-30* days from now to *now*.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**Second period** (hereinafter referred to as **current period**) lasts from *-30* days from now to *now*.
**Second period** (hereinafter referred to as **current period**) lasts from *now - 30 days* to *now*.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion. Changed.
image

@hiddenshadow21
Copy link
Contributor

After the merge of #1895 you might need to move your files to Documentation/6.0/...

@PFYasu
Copy link
Contributor Author

PFYasu commented Sep 23, 2024

After the merge of #1895 you might need to move your files to Documentation/6.0/...

Will do. Thanks!

@PFYasu PFYasu marked this pull request as ready for review September 25, 2024 09:22
@ppekrol ppekrol merged commit fab3444 into ravendb:master Sep 30, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants