RDoc-3052 Document breaking change for search query with wildcards #1919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejaszyk
reviewed
Oct 10, 2024
| When setting a [custom analyzer](../../indexes/using-analyzers#creating-custom-analyzers) in your index to tokenize field content, | ||
| then when querying the index, the search terms in the query will be processed according to the custom analyzer's logic. | ||
|
|
||
| The `*` will remain in the terms if the custom analyzer allows it. |
There was a problem hiding this comment.
- except
startsWithqueries likeFran*:
https://issues.hibernatingrhinos.com/issue/RavenDB-22989/Adjust-Lucene-search-method-startsWith
maciejaszyk
reviewed
Oct 10, 2024
| ##### Behavior for `6.0` and up: | ||
|
|
||
| Once wildcards are stripped by the analyzer, we no longer add them back before sending the term to the search engine. | ||
| The search terms sent to the search engine are solely based on the transformations applied by the analyzer used in the index. |
There was a problem hiding this comment.
Corax will match the behavior only for newly built indexes (ravendb/ravendb#19337).
There was a problem hiding this comment.
@maciejaszyk
if you "reset" the index - will behavior match ?
or - is it only for newly "created" Corax indexes ?
ml054
approved these changes
Oct 10, 2024
maciejaszyk
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue:
https://issues.hibernatingrhinos.com/issue/RDoc-3052/Document-breaking-change-for-search-query-with-wildcards
Searching with wildcardsin article: "Full-Text Search with Index"which includes detailed explanations + examples
The following are the relevant files to be reviewed:
C#:
@maciejaszyk pls review:
Documentation/6.0/Raven.Documentation.Pages/indexes/querying/searching.dotnet.markdown
Documentation/6.0/Samples/csharp/Raven.Documentation.Samples/Indexes/Querying/Searching.cs
Documentation/6.0/Raven.Documentation.Pages/migration/server/server-breaking-changes.markdown
Node.js:
@ml054 pls review:
Documentation/6.0/Raven.Documentation.Pages/indexes/querying/searching.js.markdown
Documentation/6.0/Samples/nodejs/indexes/querying/searching.js