Merge pull request #464 from ml054/RDBC-873

RDBC-873 Fix handling server failure in 6.0.0 client

src/Exceptions/index.ts

@@ -17,6 +17,19 @@ export function throwError(
     throw getError(errName, message, errCause, info);
 }
 
+function buildMessageWithInner(error: any) {
+    if (!error) {
+        return null;
+    }
+    if (!error.cause) {
+        return error.message;
+    }
+
+    const inner = buildMessageWithInner(error.cause);
+    return inner ? error.message + ": " + inner : error.message;
+}
+
+
 export function getError(errName: RavenErrorType, message: string): Error;
 export function getError(
     errName: string,
@@ -32,7 +45,8 @@ export function getError(
     message: string = "",
     errCause?: Error,
     info?: { [key: string]: any }): Error {
-    const error = new Error(message + (errCause ? ": " + errCause.message : ""), { cause: errCause });
+    const innerMessage = buildMessageWithInner(errCause);
+    const error = new Error(message + (innerMessage ? ": " + innerMessage : ""), { cause: errCause });
     error.name = errName;
 
     if (info) {

src/Http/RequestExecutor.ts

@@ -1924,7 +1924,7 @@ export class RequestExecutor implements IDisposable {
         const exceptionSchema = {
             url: req.uri.toString(),
             message: e.message,
-            error: `An exception occurred while contacting ${ req.uri }: ${ e.message } . ${ EOL + e.stack }`,
+            error: `An exception occurred while contacting ${ req.uri }: ${ e.message }`,
             type: e.name
         };
 

test/ExceptionTest.ts

@@ -0,0 +1,49 @@
+import { inspect } from "node:util";
+import { assertThat } from "./Utils/AssertExtensions.js";
+import { getError } from "../src/Exceptions/index.js";
+
+const inRush = new Error("I was in rush");
+const glasses = new Error("I forgot to put my classes", { cause: inRush });
+const accident = new Error("I caused accident", { cause: glasses });
+
+
+describe("Exception Test", () => {
+
+    it("can see nested causes", () => {
+        const exceptionSerialized = inspect(accident);
+
+        assertThat(exceptionSerialized)
+            .contains(inRush.message);
+
+        assertThat(exceptionSerialized)
+            .contains(glasses.message);
+
+        assertThat(exceptionSerialized)
+            .contains(accident);
+    });
+
+    it("can get error - no cause", () => {
+        const error = getError("ConflictException", "This is fake conflict");
+        const exceptionSerialized = inspect(error);
+        assertThat(exceptionSerialized)
+            .contains(error.message);
+    });
+
+    it("can get error - with cause", () => {
+        const error = getError("ConflictException", "This is fake conflict", accident);
+
+        const exceptionSerialized = inspect(error);
+
+        assertThat(exceptionSerialized)
+            .contains(error.message);
+
+        assertThat(exceptionSerialized)
+            .contains(inRush.message);
+
+        assertThat(exceptionSerialized)
+            .contains(glasses.message);
+
+        assertThat(exceptionSerialized)
+            .contains(accident);
+    });
+})