This repository has been archived by the owner on Oct 5, 2022. It is now read-only.
Adding props for better content positioning #55
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Adding the following props
useScrollHeight
useScrollWidth
heightOffset
widthOffset
Benefits
The
useScrollHeight
anduseScrollWidth
props allow you to change the logic for calculating content sizes to correctly position the menu.The
heightOffset
andwidthOffset
props allow you to set arbitrary indent values from the edge of the screen.Any additional information
In my case, the use of
scrollHeight
is required to correctly calculate the size of the context menu, provided that the initial size of the content is 0 pixels and will subsequently change using animation.