Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a test to assert RCF values are calculated correctly #349

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Conversation

raghumdani
Copy link
Collaborator

This PR ensures the RCF stats (inputInflation and averageRecordSizeBytes) are calculated based on the incremental data only.

@raghumdani raghumdani marked this pull request as ready for review August 29, 2024 01:18
@raghumdani raghumdani changed the title Calculate RCF and added test to assert RCF stats are generated correctly Adding a test to assert RCF values are calculated correctly Aug 29, 2024
@raghumdani raghumdani closed this Aug 29, 2024
@raghumdani raghumdani reopened this Aug 29, 2024
Copy link
Member

@Zyiqin-Miranda Zyiqin-Miranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!Thanks for the fix!

@raghumdani raghumdani merged commit 5a4507d into main Aug 29, 2024
3 checks passed
@raghumdani raghumdani deleted the rcf-fix branch August 29, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants