Fix finalizer typo and re-create manifests (#631)

These changes address issue #630

When trying to create one of the example RayCluster on OpenShift, it will fail with the operator reporting "cannot set blockOwnerDeletion if an ownerReference refers to a resource you can’t set finalizers on:".

As per https://sdk.operatorframework.io/docs/faqs/#after-deploying-my-operator-why-do-i-see-errors-like-is-forbidden-cannot-set-blockownerdeletion-if-an-ownerreference-refers-to-a-resource-you-cant-set-finalizers-on-, we were able to fix the issue by applying the new role.yaml that is created running make manifests after applying the changes in this PR.

helm-chart/kuberay-operator/templates/role.yaml

@@ -128,7 +128,7 @@ rules:
 - apiGroups:
   - ray.io
   resources:
-  - rayclusters/finalizer
+  - rayclusters/finalizers
   verbs:
   - update
 - apiGroups:
@@ -154,7 +154,7 @@ rules:
 - apiGroups:
   - ray.io
   resources:
-  - rayjobs/finalizer
+  - rayjobs/finalizers
   verbs:
   - update
 - apiGroups:

ray-operator/config/rbac/role.yaml

@@ -128,7 +128,7 @@ rules:
 - apiGroups:
   - ray.io
   resources:
-  - rayclusters/finalizer
+  - rayclusters/finalizers
   verbs:
   - update
 - apiGroups:
@@ -154,7 +154,7 @@ rules:
 - apiGroups:
   - ray.io
   resources:
-  - rayjobs/finalizer
+  - rayjobs/finalizers
   verbs:
   - update
 - apiGroups:

ray-operator/controllers/ray/raycluster_controller.go

@@ -66,7 +66,7 @@ type RayClusterReconciler struct {
 // Automatically generate RBAC rules to allow the Controller to read and write workloads
 // +kubebuilder:rbac:groups=ray.io,resources=rayclusters,verbs=get;list;watch;create;update;patch;delete
 // +kubebuilder:rbac:groups=ray.io,resources=rayclusters/status,verbs=get;update;patch
-// +kubebuilder:rbac:groups=ray.io,resources=rayclusters/finalizer,verbs=update
+// +kubebuilder:rbac:groups=ray.io,resources=rayclusters/finalizers,verbs=update
 // +kubebuilder:rbac:groups=core,resources=events,verbs=get;list;watch;create;update;patch;delete
 // +kubebuilder:rbac:groups=core,resources=pods,verbs=get;list;watch;create;update;patch;delete
 // +kubebuilder:rbac:groups=core,resources=pods/status,verbs=get;list;watch;create;update;patch;delete

ray-operator/controllers/ray/rayjob_controller.go

@@ -49,7 +49,7 @@ func NewRayJobReconciler(mgr manager.Manager) *RayJobReconciler {
 
 // +kubebuilder:rbac:groups=ray.io,resources=rayjobs,verbs=get;list;watch;create;update;patch;delete
 // +kubebuilder:rbac:groups=ray.io,resources=rayjobs/status,verbs=get;update;patch
-// +kubebuilder:rbac:groups=ray.io,resources=rayjobs/finalizer,verbs=update
+// +kubebuilder:rbac:groups=ray.io,resources=rayjobs/finalizers,verbs=update
 // +kubebuilder:rbac:groups=core,resources=events,verbs=get;list;watch;create;update;patch;delete
 // +kubebuilder:rbac:groups=core,resources=pods,verbs=get;list;watch;create;update;patch;delete
 // +kubebuilder:rbac:groups=core,resources=pods/status,verbs=get;list;watch;create;update;patch;delete

ray-operator/controllers/ray/rayservice_controller.go

@@ -67,7 +67,7 @@ func NewRayServiceReconciler(mgr manager.Manager) *RayServiceReconciler {
 // +kubebuilder:rbac:groups=ray.io,resources=rayservices/finalizers,verbs=update
 // +kubebuilder:rbac:groups=ray.io,resources=rayclusters,verbs=get;list;watch;create;update;patch;delete
 // +kubebuilder:rbac:groups=ray.io,resources=rayclusters/status,verbs=get;update;patch
-// +kubebuilder:rbac:groups=ray.io,resources=rayclusters/finalizer,verbs=update
+// +kubebuilder:rbac:groups=ray.io,resources=rayclusters/finalizers,verbs=update
 // +kubebuilder:rbac:groups=core,resources=events,verbs=get;list;watch;create;update;patch;delete
 // +kubebuilder:rbac:groups=core,resources=pods,verbs=get;list;watch;create;update;patch;delete
 // +kubebuilder:rbac:groups=core,resources=pods/status,verbs=get;list;watch;create;update;patch;delete