Skip to content

Commit

Permalink
Drop unused configmaps/status permission + configurable binary path
Browse files Browse the repository at this point in the history
Configmaps have no status; omiting this to avoid operator having to
be granted that non existing subresource:
https://github.com/kubernetes/kubernetes/blob/v1.31.2/pkg/apis/core/types.go#L1722-L1743
```
$ kubectl get configmap --subresource status myconfigmap        # k8s v1.28
Error from server (NotFound): the server could not find the requested resource
```

Supporting overriding the operator's binary path can be useful for
custom rebuilds, or using a wrapper, ...
  • Loading branch information
bpineau committed Oct 28, 2024
1 parent fb1463f commit f5d60b1
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 9 deletions.
2 changes: 1 addition & 1 deletion helm-chart/kuberay-operator/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ spec:
mountPath: "{{ .Values.logging.baseDir }}"
{{- end }}
command:
- /manager
- {{ .Values.operatorComand }}
args:
{{- $argList := list -}}
{{- $argList = append $argList (include "kuberay.featureGates" . | trim) -}}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,6 @@ rules:
- update
- patch
- delete
- apiGroups:
- ""
resources:
- configmaps/status
verbs:
- get
- update
- patch
- apiGroups:
- ""
resources:
Expand Down
2 changes: 2 additions & 0 deletions helm-chart/kuberay-operator/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,8 @@ featureGates:
- name: RayClusterStatusConditions
enabled: false

# Path to the operator binary
operatorComand: /manager

# Set up `securityContext` to improve Pod security.
# See https://github.com/ray-project/kuberay/blob/master/docs/guidance/pod-security.md for further guidance.
Expand Down

0 comments on commit f5d60b1

Please sign in to comment.