Parametrize ray operator makefile to support other container engines (#…

…1121)

Parametrize ray operator makefile to support other container engines

ray-operator/DEVELOPMENT.md

@@ -10,6 +10,8 @@ kubectl |  v1.21.0+    | [download](https://kubernetes.io/docs/tasks/tools/insta
 go  | v1.17|[download](https://golang.org/dl/)
 docker   | 19.03+|[download](https://docs.docker.com/install/)
 
+Alternatively, you can use podman (version 4.5+) instead of docker. See [podman.io](https://podman.io/getting-started/installation) for installation instructions. The Makefile allows you to specify the container engine to use via the `ENGINE` variable. For example, to use podman, you can run `ENGINE=podman make docker-build`.
+
 The instructions assume you have access to a running Kubernetes cluster via ``kubectl``. If you want to test locally, consider using [Minikube](https://kubernetes.io/docs/tasks/tools/install-minikube/).
 
 ### Setup on Kind
@@ -46,7 +48,7 @@ kind create cluster --image=kindest/node:v1.24.0
 # Step 2: Modify KubeRay source code
 # For example, add a log "Hello KubeRay" in the function `Reconcile` in `raycluster_controller.go`.
 
-# Step 3: Build a Docker image
+# Step 3: Build an image
 #         This command will copy the source code directory into the image, and build it.
 # Command: IMG={IMG_REPO}:{IMG_TAG} make docker-build
 IMG=kuberay/operator:nightly make docker-build

ray-operator/Makefile

@@ -20,6 +20,9 @@ endif
 SHELL = /usr/bin/env bash -o pipefail
 .SHELLFLAGS = -ec
 
+# Container Engine to be used for building images
+ENGINE ?= "docker"
+
 all: build
 
 ##@ General
@@ -82,12 +85,12 @@ run: manifests generate fmt vet ## Run a controller from your host.
 	go run ./main.go
 
 docker-image: ## Build image only
-	docker build -t ${IMG} .
+	${ENGINE} build -t ${IMG} .
 
-docker-build: test docker-image ## Build docker image with the manager.
+docker-build: test docker-image ## Build image with the manager.
 
-docker-push: ## Push docker image with the manager.
-	docker push ${IMG}
+docker-push: ## Push image with the manager.
+	${ENGINE} push ${IMG}
 
 ##@ Deployment