Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Custom labels are not pulled in for kuberay-operator and kuberay-apiserver #1391

Closed
2 tasks done
rxraghu opened this issue Sep 5, 2023 · 0 comments · Fixed by #1398
Closed
2 tasks done

[Bug] Custom labels are not pulled in for kuberay-operator and kuberay-apiserver #1391

rxraghu opened this issue Sep 5, 2023 · 0 comments · Fixed by #1398
Labels
bug Something isn't working

Comments

@rxraghu
Copy link
Contributor

rxraghu commented Sep 5, 2023

Search before asking

  • I searched the issues and found no similar issues.

KubeRay Component

ray-operator, apiserver

What happened + What you expected to happen

Our production kubernetes setup requires us to have certain labels on all deployments, daemonsets, pods and statefulsets. Currently deployment.yaml for both kuberay-operator and kuberay-apiserver pull in labels from kuberay-operator.labels or kuberay-apiserver.labels that is defined in _helpers.tpl only and not from .Values due to this additional custom labels cannot be added on to the deployments. Also, the spec template metadata for kuberay-operator pulls in the labels from .Values but the same is missing from the kuberay-apiserver.

Reproduction script

  1. Download kuberay-operator and kuberay-apiserver helm charts from here
  2. cd into respective directory
  3. Add a labels section with a dummy label dummy-label: "dummy" in values.yaml for both operator and apiserver.
  4. Run helm install kuberay-operator . and helm install kuberay-apiserver . respectively
  5. Run kubectl get deployments to make sure both operator and apiserver are deployed
  6. Run kubectl describe deployment kuberay-operator, you will see that the deployment does not have the dummy-label but the pod template has the dummy-label.
  7. Run kubectl describe deployment kuberay-apiserver, you will see that neither the deployment nor the pod template has the dummy-label.

Anything else

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@rxraghu rxraghu added the bug Something isn't working label Sep 5, 2023
rxraghu added a commit to rxraghu/kuberay that referenced this issue Sep 6, 2023
kevin85421 pushed a commit that referenced this issue Sep 8, 2023
fix: Issue #1391 - Custom labels not being pulled in
z103cb pushed a commit to z103cb/kuberay that referenced this issue Sep 11, 2023
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this issue Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant