Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature][GCS FT] Test the behavior of cleanup_redis_storage #1422

Open
1 of 2 tasks
Tracked by #1033
kevin85421 opened this issue Sep 15, 2023 · 4 comments
Open
1 of 2 tasks
Tracked by #1033

[Feature][GCS FT] Test the behavior of cleanup_redis_storage #1422

kevin85421 opened this issue Sep 15, 2023 · 4 comments
Assignees
@rueian
Labels
enhancement New feature or request gcs ft good first issue Good for newcomers

Comments

@kevin85421
Copy link
Member

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

Use case

No response

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@kevin85421 kevin85421 added enhancement New feature or request good first issue Good for newcomers labels Sep 15, 2023
This was referenced Sep 15, 2023
Merged
Open
@kevin85421
Copy link
Member Author

@rueian are you interested in this issue?

@rueian
Copy link
Contributor

rueian commented Sep 16, 2023

Sure!

rueian added a commit to rueian/kuberay that referenced this issue Oct 1, 2023
@rueian
[Test][GCS FT] End-to-end test for cleanup_redis_storage (ray-project…
27a9f7c 
…#1422)(ray-project#1459)
@rueian rueian mentioned this issue Oct 1, 2023
Merged
4 tasks
@rueian rueian mentioned this issue Oct 13, 2023
Merged
4 tasks
@kevin85421
Copy link
Member Author

If the function cleanup_redis_storage can connect to Redis but fails to delete, for instance, if the key is non-existent, it will fail immediately. However, if cleanup_redis_storage cannot connect to Redis, it will retry according to the environment variables redis_db_connect_retries and redis_db_connect_wait_milliseconds. We need to ensure that these retries are completed within a specific period, such as between 2 and 5 minutes.

@kevin85421
Copy link
Member Author

Related issues / PRs:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rueian rueian

Labels
enhancement New feature or request gcs ft good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rueian @kevin85421