Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add Helm Chart Checker in CI #184

Closed
1 of 2 tasks
Jeffwan opened this issue Mar 10, 2022 · 6 comments
Closed
1 of 2 tasks

[Feature] Add Helm Chart Checker in CI #184

Jeffwan opened this issue Mar 10, 2022 · 6 comments
Assignees
Labels
deployment enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed P1 Issue that should be fixed within a few weeks

Comments

@Jeffwan
Copy link
Collaborator

Jeffwan commented Mar 10, 2022

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

This is requested from @chenk008 in #175 (comment).

We maintain both the kustomize and helm manifests. Currently, we do use kustomize to deploy the control plane and validate cluster creations etc in CI. However, we lack of tests to validate helm chart changes. This can be improved by adding helm chart checker in CI.

/cc @ebr @Chenk

Use case

Validate helm manifest changes make sure it's working

Related issues

#175

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@Jeffwan Jeffwan added the enhancement New feature or request label Mar 10, 2022
@Jeffwan Jeffwan added deployment good first issue Good for newcomers help wanted Extra attention is needed labels May 30, 2022
@DmitriGekhtman
Copy link
Collaborator

It's partially covered by #554.

What remains to be done is to add KinD CI integration tests that validate that the charts work end-to-end.

@DmitriGekhtman
Copy link
Collaborator

What remains to be done is to add KinD CI integration tests that validate that the charts work end-to-end.

A basic e2e sanity check that we can use Helm to deploy a 1-head and 1-worker Ray cluster with the latest Ray version would be sufficient.

@DmitriGekhtman DmitriGekhtman added the P1 Issue that should be fixed within a few weeks label Sep 14, 2022
@DmitriGekhtman
Copy link
Collaborator

We can use existing compatibility test code as a starting point for this.

@DmitriGekhtman DmitriGekhtman added this to the v0.4.0 release milestone Nov 4, 2022
@DmitriGekhtman
Copy link
Collaborator

@kevin85421 for the KubeRay 0.4.0 release we should add a e2e CI test that validates that at least the default values.yaml works

@DmitriGekhtman
Copy link
Collaborator

DmitriGekhtman commented Nov 4, 2022

If we can't add it to CI before 0.4.0, we should at least test manually.

@DmitriGekhtman
Copy link
Collaborator

Again, not a hard blocker for the 0.4.0 release, but we do need to at least do some manual testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed P1 Issue that should be fixed within a few weeks
Projects
None yet
Development

No branches or pull requests

3 participants