Helm: ensure RBAC rules are up to date with the latest autogenerated manifest

[ebr]

Updates RBAC rules in the Helm template to match those generated by the Operator Framework based on the application code.

Why are these changes needed?

The update was initially needed because after deploying the kuberay-operator nightly build, its service account was unable to access leases in the coordination.k8s.io API group. Further investigation revealed that the Helm manifest was even further outdated, which is fixed by this PR.

Fixes #174

Checks

• I've made sure the tests are passing.
• Testing Strategy
  • Unit tests
  • Manual tests
  • This PR is not tested :(

[Jeffwan]

@ebr Thanks for the contribution. We did talk about the consistency between kustomize and helm.. ideally, we should have source of truth and the other one can be generated from it. However, currently seems there's no a perfect way to make it.

I will add some notes in development.md later to reminder contributors to make corresponding change if RBAC is changed in the PR.

[chenk008]

Add a checker in CI?

[ebr]

Add a checker in CI?

That would be helpful. Ideally CI itself would automate the chore of copying the rules: from the Kustomize manifest into the Helm template, but I'm a bit unsure about the whole "allowing CI to commit back to the repo" thing.

Generally, is Helm to be supported going forward? looks like the Kustomize manifests are ahead of the chart in a few other ways. We're likely to switch to Kustomize, but this wasn't obvious to me at all, and I wonder if this is confusing to other users.

[ebr]

(sorry about all those force-pushes to our source repo; I made a mistake when opening the PR, but rather than opening a new one, I'm hoping for this one to get merged).

[Jeffwan]

(sorry about all those force-pushes to our source repo; I made a mistake when opening the PR, but rather than opening a new one, I'm hoping for this one to get merged).

That's not a problem. :D

[Jeffwan]

Let's work on the CI in a separate PR.