Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Expose Cluster State via cluster.status and api response #223

Closed
1 of 2 tasks
Jeffwan opened this issue Apr 6, 2022 · 8 comments · Fixed by #341
Closed
1 of 2 tasks

[Feature] Expose Cluster State via cluster.status and api response #223

Jeffwan opened this issue Apr 6, 2022 · 8 comments · Fixed by #341
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Jeffwan
Copy link
Collaborator

Jeffwan commented Apr 6, 2022

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

Currently, we have not leveraged state field well in our implementation. This is critical because our caller need detail information to let user know the exact stage the cluster is at.

  1. Define key stage in cluster CRD and emit events.
  2. Reuse those information and expose them to apiserver get/list response

Use case

No response

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@Jeffwan Jeffwan added the enhancement New feature or request label Apr 6, 2022
@Jeffwan Jeffwan added the help wanted Extra attention is needed label May 30, 2022
@daikeshi
Copy link
Contributor

daikeshi commented Jun 14, 2022

+1 to this! cc @davidxia

We also need to access cluster status (e.g. ray cluster readiness, head node ip, etc) info in our Ray cluster management lifecycle.

@davidxia
Copy link
Contributor

@Jeffwan happy to contribute something. Just need someone to sketch out an approach or some tips.

@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Jun 15, 2022

/cc @scarlet25151 Can you reach out to @daikeshi and @daikeshi to see whether our internal change meet Spotify's case? I think we forgot to upstream this change.

If there's additional changes to make, we can ask spotify engineers' help.

@daikeshi
Copy link
Contributor

Thanks @Jeffwan! That's awesome. @scarlet25151 please let @davidxia and me know if there's anything we can help with.

@scarlet25151
Copy link
Collaborator

Hi @daikeshi and @davidxia , we have designed and implemented some state machine for raycluster lifecycle and expose some status like ports and state. Let's discuss more detail about what we have and what you would like for the raycluster lifecycle and then we can start the work, shall we call a meeting?

@daikeshi
Copy link
Contributor

Thanks @scarlet25151. Look forward to the collaboration! Let's chat more on the slack.

@asm582
Copy link
Contributor

asm582 commented Jun 19, 2022

Can we please know the different states that we are planning to expose?

@scarlet25151
Copy link
Collaborator

@asm582 sure for now we will implement the state, the design would look like in the doc: kuberay state design

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
5 participants