-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ray head service endpoints in status for expose raycluster's head node endpoints #341
Add ray head service endpoints in status for expose raycluster's head node endpoints #341
Conversation
Let's try to make the PR title self explainable. |
7608ef2
to
a3b014c
Compare
@scarlet25151 please rebase the master changes. What's wrong with the compatibility tests? |
ae8f98a
to
cce9d1d
Compare
cce9d1d
to
a51e8be
Compare
instead of NodePort which is usually "0" for updating RayCluster's `status.endpoints`. follow up to ray-project#341
@scarlet25151 thanks! I think there's a bug and made a draft #383. Are there plans to include the head node's pod IP in the API Cluster response too? Happy to make a PR for that if we're OK with it. |
@davidxia Great, I think the draft is reasonable and thank you for the draft. I think it's a good idea to include the head node's pod IP in the API cluster response. It would be greate that you would make a PR. Btw, from the point of extensibility, I would recommend we add a string map like: |
instead of NodePort which is usually "0" for updating RayCluster's `status.endpoints`. follow up to ray-project#341
instead of NodePort which is usually "0" for updating RayCluster's `status.endpoints`. follow up to ray-project#341
instead of NodePort which is usually "0" for updating RayCluster's `status.endpoints`. follow up to ray-project#341
instead of NodePort which is usually "0" for updating RayCluster's `status.endpoints`. follow up to ray-project#341
@scarlet25151 nice, #383 is now ready for review. I've also drafted davidxia#1 for adding a |
instead of NodePort which is usually "0" for updating RayCluster's `status.endpoints`. follow up to ray-project#341
instead of NodePort which is usually "0" for updating RayCluster's `status.endpoints`. follow up to ray-project#341
if NodePort is "0" for updating RayCluster's `status.endpoints`. follow up to ray-project#341
if NodePort is "0" for updating RayCluster's `status.endpoints`. follow up to ray-project#341
if NodePort is "0" for updating RayCluster's `status.endpoints`. follow up to #341
Co-authored-by: chenyu.jiang <[email protected]>
if NodePort is "0" for updating RayCluster's `status.endpoints`. follow up to ray-project#341
Why are these changes needed?
Related issue number
Closes #223
Checks