Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] It's not easy to filter kuberay components in Kubernetes #338

Closed
2 tasks done
Jeffwan opened this issue Jul 5, 2022 · 3 comments
Closed
2 tasks done

[Feature] It's not easy to filter kuberay components in Kubernetes #338

Jeffwan opened this issue Jul 5, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@Jeffwan
Copy link
Collaborator

Jeffwan commented Jul 5, 2022

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

Currently, we tag kuberay deployment with label control-plane=kuberay-operator, control-plane=kuberay-apiserver.

Name:                   kuberay-apiserver
Namespace:              ray-system
CreationTimestamp:      Tue, 05 Jul 2022 10:21:35 -0700
Labels:                 control-plane=kuberay-apiserver
Annotations:            deployment.kubernetes.io/revision: 1
Selector:               control-plane=kuberay-apiserver

However, there's no easy way to filter all kuberay resources. It's better to give a consistent app level label that can be used to filter kuberay resources.

Use case

Operation purpose. This would be helpful especially when we deploy lots of application in single namespace and operators need to filter some pods or resources out.

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@Jeffwan Jeffwan added the enhancement New feature or request label Jul 5, 2022
@Jeffwan Jeffwan self-assigned this Jul 5, 2022
@Jeffwan Jeffwan added this to the v0.3.0 release milestone Jul 5, 2022
@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Jul 5, 2022

guidance: https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/

app.kubernetes.io/name: kuberay
app.kubernetes.io/component: kuberay-apiserver

@DmitriGekhtman
Copy link
Collaborator

@Jeffwan is this good to close after #345?

@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Jul 7, 2022

@DmitriGekhtman Yes. we can close this one

@Jeffwan Jeffwan closed this as completed Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants