add standard label for the filtering of cluster #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I create #338 for other reason. I will cut a PR to add labels to manifest. |
Jeffwan
requested changes
Jul 6, 2022
scarlet25151
force-pushed
the
enhancement/add-standard-label
branch
2 times, most recently
from
7b58d6c
to
18acf6c
Compare
Jeffwan
reviewed
Jul 6, 2022
Jeffwan
reviewed
Jul 6, 2022
Jeffwan
reviewed
Jul 6, 2022
|
@scarlet25151 I have some more comments on the naming, please address them |
scarlet25151
force-pushed
the
enhancement/add-standard-label
branch
from
18acf6c
to
2242085
Compare
|
It looks good to me now |
Jeffwan
approved these changes
Jul 6, 2022
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
Co-authored-by: chenyu.jiang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
#338
Checks