Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Duplicate namespace setting when we create config template #347

Closed
2 tasks done
Jeffwan opened this issue Jul 6, 2022 · 4 comments
Closed
2 tasks done

[Bug] Duplicate namespace setting when we create config template #347

Jeffwan opened this issue Jul 6, 2022 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@Jeffwan
Copy link
Collaborator

Jeffwan commented Jul 6, 2022

Search before asking

  • I searched the issues and found no similar issues.

KubeRay Component

apiserver

What happened + What you expected to happen

image

Seems this is unnecessary and we should improve the post request experience

Reproduction script

image

Anything else

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@Jeffwan Jeffwan added the bug Something isn't working label Jul 6, 2022
@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Jul 6, 2022

namespace in the payload seems doesn't working.

The namespace is from the request path which is required. for the inconsistency issue, I think we just need to add additional logic to force user to give consistent data.

rpc CreateCluster(CreateClusterRequest) returns (Cluster) {
option (google.api.http) = {
post: "/apis/v1alpha2/namespaces/{namespace}/clusters"
body: "cluster"
};
}

message CreateClusterRequest {
// The cluster to be created.
Cluster cluster = 1;
// The namespace of the cluster to be created.
string namespace = 2;
}


Update: I synced with @daikeshi offline and he will cut a PR.

@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Jul 6, 2022

image
image

cluster namespace setting and template setting are inconsistent


Update: I think we forget to refactor the compute_template CREATE earlier?
@daikeshi

image

I filed a PR https://github.com/ray-project/kuberay/pull/363/files to address this issue

@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Jul 6, 2022

image

This has been fixed in master

@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Jul 6, 2022

Create a new issue #364 for status codes enhancement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant