Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Improve apiserver error codes #364

Closed
2 tasks done
Jeffwan opened this issue Jul 8, 2022 · 0 comments
Closed
2 tasks done

[Feature] Improve apiserver error codes #364

Jeffwan opened this issue Jul 8, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@Jeffwan
Copy link
Collaborator

Jeffwan commented Jul 8, 2022

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

We use grpc-gateway to expose HTTP service. Currently, for any errors, it returns HTTP 500 code and user may need to unpack the error message and parse .code to understand the detail problem. This brings challenges to system integration, we would like to keep our self-define code there. At the same time, it's better for us to expose common used codes like 401, 404, 405 directly for upstream system to interact with.

image
Should be 404

image
Should be 401

Use case

Use for system integration

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant