-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature][RFC] RayCluster CRD: interface cleanup #368
Comments
If that's optional, are there minimum configs to make Ray start up work? If so, we can append args on behalf of users.
Agree. Bytedance enable it by default in downstream version.
Agree. Additionally, we added these fields in CRD in the past. We are considering to move these fields to annotation instead. |
Besides what we already do, it may just be --block. We should double-check. |
cc @kevin85421 @sihanwang41 on the entry-point issues |
#861 If we plan to make any API changes (remove any unhelpful fields), clean up is a breaking change and let's support multi version in beta version. |
The last TODO is #976. Close this issue. |
Search before asking
Description
Minimal configuration for RayCluster CRs should be as simple as possible. Some suggestions:
{}
is valid, not specifying the field at all should also be valid.--block
. The current default behavior of adding a "sleep infinity" after ray start is unintuitive and probably incorrect.Use case
Make default configuration as simple and minimal as possible for standard use-cases.
Related issues
No response
Are you willing to submit a PR?
The text was updated successfully, but these errors were encountered: