Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Managing multiple CRD versions at the same time #861

Closed
1 of 2 tasks
Jeffwan opened this issue Jan 5, 2023 · 4 comments
Closed
1 of 2 tasks

[Feature] Managing multiple CRD versions at the same time #861

Jeffwan opened this issue Jan 5, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request P0 Critical issue that should be fixed ASAP rayservice

Comments

@Jeffwan
Copy link
Collaborator

Jeffwan commented Jan 5, 2023

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

Follow up story of #536.

We will have multiple tracking issues may update the CRDs in v0.5.0 release. It's a good time to talk about multi-version management now. I highly recommend to bump to v1beta1 CRD before we come into v1. (We expect v1beta1 would be same as v1 though)

One thing to notice is conversion does introduce webhook and it make deployment a little pretty heavy.

Use case

Use to manage multiple CRD versions and help user upgrade to new version smoothly.

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@Jeffwan Jeffwan added the enhancement New feature or request label Jan 5, 2023
@akanso
Copy link
Collaborator

akanso commented Jan 6, 2023

do we have a compelling case for backward compatibility?

in v1beta1 are we planning to break the API, that is the CRD definition will change and the previous CRs will not parse properly?

KubeRay upcoming major version is still 0. that is, 0.5.x, it would be unusual to have the CRD version v1 when kuberay is still in "v0"

@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Feb 23, 2023

@akanso Yes, some unhelpful fields like head.replicas should be reused. There're some fields that can be changed to use annotation instead could be removed as well.

Previous CR can still work with the webhook conversion. That's the backward compatibility the project should guarantee. Let's write more details for this one.

@kevin85421 kevin85421 self-assigned this May 27, 2023
@kevin85421 kevin85421 added P0 Critical issue that should be fixed ASAP rayservice labels May 27, 2023
@kevin85421
Copy link
Member

I will try to bump RayService from v1alpha1 to v1beta1 or v1alpha2 next week.

@kevin85421
Copy link
Member

I will bump the CRD version to v1. In addition, after discussing with several users and experts on CRD versioning, we have decided not to go with a conversion webhook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P0 Critical issue that should be fixed ASAP rayservice
Projects
None yet
Development

No branches or pull requests

4 participants