Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] .status.availableWorkerReplicas incorrectly counts head Pods #885

Closed
2 tasks done
davidxia opened this issue Jan 27, 2023 · 2 comments · Fixed by #887
Closed
2 tasks done

[Bug] .status.availableWorkerReplicas incorrectly counts head Pods #885

davidxia opened this issue Jan 27, 2023 · 2 comments · Fixed by #887
Assignees
Labels
bug Something isn't working

Comments

@davidxia
Copy link
Contributor

Search before asking

  • I searched the issues and found no similar issues.

KubeRay Component

ray-operator

What happened + What you expected to happen

kubectl get raycluster my-cluster -o yaml shows .status.availableWorkerReplicas as always one more than .status.desiredWorkerReplicas. I think the operator is incorrectly including head Pods in availableWorkerReplicas.

see previous comment

Reproduction script

Create a RayCluster with workers. Run kubectl get raycluster my-cluster -o yaml and look at .status.

Anything else

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@davidxia davidxia added the bug Something isn't working label Jan 27, 2023
@davidxia
Copy link
Contributor Author

@kevin85421 @Jeffwan I'm happy to work on this if the bug report looks good to you. Probably a straight forward fix.

@kevin85421
Copy link
Member

Thanks, @davidxia!

davidxia added a commit to davidxia/kuberay that referenced this issue Jan 28, 2023
davidxia added a commit to davidxia/kuberay that referenced this issue Jan 29, 2023
davidxia added a commit to davidxia/kuberay that referenced this issue Jan 30, 2023
davidxia added a commit to davidxia/kuberay that referenced this issue Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants