Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] rayStartParams is required at this moment. #1031

Merged
merged 2 commits into from
Apr 18, 2023

Conversation

kevin85421
Copy link
Member

@kevin85421 kevin85421 commented Apr 17, 2023

Why are these changes needed?

(base) ➜  ray-cluster git:(fix-helm-chart) helm install raycluster .
Error: INSTALLATION FAILED: unable to build kubernetes objects from release manifest: error validating "": error validating data: ValidationError(RayCluster.spec.workerGroupSpecs[0]): missing required field "rayStartParams" in io.ray.v1alpha1.RayCluster.spec.workerGroupSpecs

Currently, rayStartParams is a required field now, so we need to use rayStartParams: {} if rayStartParams in values.yaml is empty.

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(
# head
rayStartParams:
  dashboard-host: '0.0.0.0'
initArgs:
  111: 222

# path: helm-chart/ray-cluster/
helm template .

# worker
rayStartParams: {}
initArgs:
  111: 222

# path: helm-chart/ray-cluster/
helm template .

@kevin85421 kevin85421 marked this pull request as ready for review April 17, 2023 22:46
@kevin85421 kevin85421 merged commit 0672956 into ray-project:master Apr 18, 2023
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants