Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gRPC service definition and gRPC gateway #112

Merged
merged 3 commits into from
Jan 14, 2022

Conversation

Jeffwan
Copy link
Collaborator

@Jeffwan Jeffwan commented Dec 14, 2021

Why are these changes needed?

This change defines the grpc service and we will use it to generate skeleton code to build the backend services

Related issue number

#83 #85

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Dec 14, 2021

Sorry for late. I was overwhelmed by some internal work and this is a little bit delayed.

@chenk008 chenk008 self-requested a review January 14, 2022 06:04
Copy link
Contributor

@chenk008 chenk008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Jeffwan Jeffwan merged commit 5d790a6 into ray-project:master Jan 14, 2022
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
* [proto] Add third_party proto definitions

* [proto] Update proto to include service definition

* [proto] Add Makefile and README.md for proto folder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants