[WIP] Add RayCluster v1beta1 and Conversion webhook #1146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
“kubebuilder create api --group ray --version v1beta1 --kind RayCluster” Signed-off-by: Jiaxin Shan <[email protected]>
- Use v1alpha1 as the default storage version - make generate - make manifests Signed-off-by: Jiaxin Shan <[email protected]>
kubebuilder create webhook --group ray --version v1alpha1 --kind RayCluster --conversion Signed-off-by: Jiaxin Shan <[email protected]>
|
I notice @kevin85421 filed a PR #1132 here. We can use that one if that's ready. |
|
We decide not to have conversion webhook. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
We need to stablize the API version and introduce the version upgrade policy for future changes.
Related issue number
Checks