[RayService] Add RayService alb ingress CR #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sihan Wang <[email protected]>
Signed-off-by: Sihan Wang <[email protected]>
Signed-off-by: Sihan Wang <[email protected]>
shrekris-anyscale
approved these changes
Jun 15, 2023
| # Health Check Settings | ||
| alb.ingress.kubernetes.io/healthcheck-protocol: HTTP | ||
| alb.ingress.kubernetes.io/healthcheck-port: traffic-port | ||
| alb.ingress.kubernetes.io/healthcheck-path: /-/routes |
There was a problem hiding this comment.
What's the behavior if this health check fails? Does traffic simply stop flowing to the pod, or does the pod get restarted?
There was a problem hiding this comment.
yes, traffic will stop sending traffic to the pod. (if there is only one pod which is unhealthy, the traffic will still be sent to that pod.)
No operation on the pod. it still relies on the kuberay operation to take care of it.
There was a problem hiding this comment.
Sounds good, that makes sense.
kevin85421
reviewed
Jun 15, 2023
ray-operator/config/samples/ray_v1alpha1_rayservice-alb-ingress.yaml
Outdated
Show resolved
Hide resolved
kevin85421
reviewed
Jun 15, 2023
Signed-off-by: Sihan Wang <[email protected]>
|
The change has no relationship with CI. Merge it. |
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
[RayService] Add RayService alb ingress CR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
three updates comparing with this
rayservice-sample-serve-svcWith these two changes, customer will have workable CR out of the box for Ray Service.
Tested with eks.
I will put more details into the ray doc.
Related issue number
Checks