-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for openshift routes #1183
Add support for openshift routes #1183
Conversation
@kevin85421, can you, please, take a look at the errors, they do not seem to be related to my PR |
@kevin85421, nm, fixed it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind providing more details about how to manually test it? Unfortunately, I don't have access to OpenShift, so I am unable to test it by myself.
name: {{ $fullName }} | ||
labels: | ||
{{- include "kuberay-apiserver.labels" . | nindent 4 }} | ||
{{- with .Values.route.annotations }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we use with
here instead of if
? In this YAML file, we have used if
twice and with
once. Should we strive for consistency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This again is copied from ingress.yaml and does work
You just run |
Of course |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Add support for openshift routes
Why are these changes needed?
API server Helm chart allows creating an ingress, but for the OpenShift, the default way to expose services is the usage of Route. This PR adds support for Routes creation
Related issue number
Checks