Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for openshift routes #1183

Merged
merged 3 commits into from
Jun 26, 2023

Conversation

blublinsky
Copy link
Contributor

Why are these changes needed?

API server Helm chart allows creating an ingress, but for the OpenShift, the default way to expose services is the usage of Route. This PR adds support for Routes creation

Related issue number

Checks

  • [ x] I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • [x ] Manual tests
    • This PR is not tested :(

@blublinsky
Copy link
Contributor Author

@kevin85421, can you, please, take a look at the errors, they do not seem to be related to my PR

@blublinsky
Copy link
Contributor Author

@kevin85421, nm, fixed it

Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind providing more details about how to manually test it? Unfortunately, I don't have access to OpenShift, so I am unable to test it by myself.

helm-chart/kuberay-apiserver/values.yaml Show resolved Hide resolved
name: {{ $fullName }}
labels:
{{- include "kuberay-apiserver.labels" . | nindent 4 }}
{{- with .Values.route.annotations }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we use with here instead of if? In this YAML file, we have used if twice and with once. Should we strive for consistency?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This again is copied from ingress.yaml and does work

@blublinsky
Copy link
Contributor Author

Would you mind providing more details about how to manually test it? Unfortunately, I don't have access to OpenShift, so I am unable to test it by myself.

You just run helm install to install it on OpenShift cluster

@anishasthana
Copy link
Contributor

I ran helm install kuberay . from the helm-chart/kuberay-apiserver directory. The following route is created in an OpenShift Cluster
image

@kevin85421
Copy link
Member

I ran helm install kuberay . from the helm-chart/kuberay-apiserver directory. The following route is created in an OpenShift Cluster image

Have you ever sent a request via the route to check if the KubeRay API Server can receive the request and create a RayCluster successfully? If so, I will merge this PR.

@blublinsky
Copy link
Contributor Author

Have you ever sent a request via the route to check if the KubeRay API Server can receive the request and create a RayCluster successfully? If so, I will merge this PR.

Of course

Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kevin85421 kevin85421 merged commit 224a444 into ray-project:master Jun 26, 2023
@blublinsky blublinsky deleted the apiserver_oc_support branch July 7, 2023 08:10
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants