Update ray operator Dockerfile #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anish Asthana <[email protected]>
Signed-off-by: Anish Asthana <[email protected]>
anishasthana
force-pushed
the
update_ray_operator
branch
from
423a672
to
b367a33
Compare
anishasthana
changed the title
|
@kevin85421 can you retrigger CI here? |
kevin85421
reviewed
Jul 28, 2023
Some build systems are unable to pull images from public "non-trusted" registries, so gcr.io (or even quay/dockerhub) would be out of the question unless you go through approval processes. As |
|
@kevin85421 bump on this |
2 tasks
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
Update ray operator Dockerfile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
We are currently using generic golang and distroless images to build the ray-operator (and other images).
Using “ubi(universal base image)” and “scratch” will improve the security of our images. UBI images are actively maintained, scanned, and updated by Red Hat productization and security teams. Using these images will improve user confidence in what is being provided by the KubeRay community.
scratchis similar to the distroless, but this will make the dockerfile more portable for build systems that are unable to accessgcr.io/distroless/staticRelated issue number
Not directly related, but we should really update the Go version we are using: #518
Go 1.17 seems to have a lot of vulnerabilities. I'll see if I have some time in the next couple weeks to update it.
Checks
I'm happy to create an issue if required. cc @kevin85421