Generate go clients and swagger files #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeffwan
force-pushed
the
proto_generation
branch
from
54d4c7d
to
1c0ad58
Compare
|
To make the CI pass. I make minor changes to arguments of |
| @@ -74,7 +74,7 @@ jobs: | |||
| run: go get golang.org/x/tools/cmd/goimports | |||
|
|
|||
| - name: Run goimports | |||
| run: test -z "$(set -o pipefail && $(go env GOPATH)/bin/goimports -l . | tee goimports.out)" || { cat goimports.out && exit 1; } | |||
| run: test -z "$(set -o pipefail && $(go env GOPATH)/bin/goimports -l apiserver/ ray-operator/ | tee goimports.out)" || { cat goimports.out && exit 1; } | |||
4 tasks
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
* Generate go clients and swagger files * Apply goimports in specific folders
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just notice we don't have go clients and swagger generated in upstream and this leads to apiserver build failure in clean master.
Since we already give the guidance there, it's just one command to generate the codes.
Why are these changes needed?
Address #84
#85
Related issue number
#84
#85
Checks