Implement resource manager and gRPC services #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeffwan
force-pushed
the
apiserver_part_2
branch
from
0f86d2c
to
261c06b
Compare
4 tasks
|
/cc @chenk008 I did some refactor for grpc service based on upstream proto definitions. There're some limitations and I will explain the details so Ant Group folks can help enhance them later. |
Jeffwan
force-pushed
the
apiserver_part_2
branch
2 times, most recently
from
09095bc
to
cfb0562
Compare
Jeffwan
force-pushed
the
apiserver_part_2
branch
from
cfb0562
to
4156f7b
Compare
chenk008
reviewed
Jan 21, 2022
| return getComputeTemplateByName(ctx, client, name) | ||
| } | ||
|
|
||
| func (r *ResourceManager) ListComputeTemplates(ctx context.Context) ([]*v1.ConfigMap, error) { |
There was a problem hiding this comment.
Is computeTemplate saved in configmap?
There was a problem hiding this comment.
Yes. That's true. We can change to db or annotations if needed later.
|
LGTM, thanks! |
chenk008
approved these changes
Jan 21, 2022
lowang-bh
pushed a commit
to lowang-bh/kuberay
that referenced
this pull request
Sep 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Implement the gPRC service and provide the interface for cluster CRUD operations.
Related issue number
#87
Checks