Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Allow custom labels&annotations for kuberay operator (#1275) #1276

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

mariusp
Copy link
Contributor

@mariusp mariusp commented Jul 28, 2023

Why are these changes needed?

Some custom Kubernetes clusters require special labels and annotations for pods, which currently can not be set.
This PR allows setting custom labels on the kuberay operator.
(#1275)

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I tested it manually.

Screen Shot 2023-07-28 at 1 14 02 PM

@kevin85421 kevin85421 merged commit 002e375 into ray-project:master Jul 28, 2023
18 checks passed
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants