Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Golang] Remove go get #1283

Merged
merged 1 commit into from
Aug 1, 2023
Merged

[Golang] Remove go get #1283

merged 1 commit into from
Aug 1, 2023

Conversation

ijrsvt
Copy link
Contributor

@ijrsvt ijrsvt commented Aug 1, 2023 •
edited
Loading

Why are these changes needed?

  • Removes dependency on go get to unblock further Golang upgrades

Related issue number

Should close #518

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@ijrsvt ijrsvt requested a review from kevin85421 August 1, 2023 21:26
kevin85421
kevin85421 approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevin85421 kevin85421 merged commit 6375221 into ray-project:master Aug 1, 2023
18 checks passed
@kevin85421 kevin85421 mentioned this pull request Aug 1, 2023
Closed
2 tasks
@kevin85421
Copy link
Member

Some follow-up #518 (comment)

lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
@ijrsvt
[Golang] Remove go get (ray-project#1283)
80a6d98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin85421 kevin85421 kevin85421 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Support go1.18+
2 participants
@ijrsvt @kevin85421