-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update doc and base image for Go 1.19 #1330
Conversation
@@ -33,3 +36,4 @@ ENV XDG_CACHE_HOME /tmp/.cache | |||
RUN chmod -R 775 /usr/bin/ | |||
RUN chmod -R 775 /usr/include/google | |||
RUN chmod -R 775 /go | |||
USER 65532:65532 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind explaining the reason behind this change? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I needed temporary root privilege to install packages. I saw this usage pattern here. @anishasthana Could you take a look if USER 65532:65532
is necessary ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it is. The alternative is that we will run the pod as root, which is pretty not-good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
cc @anishasthana would you mind taking a look? Thx! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I will merge this PR after @anishasthana approves this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. Thanks @tedhtchang!
Update doc and base image for Go 1.19
Update doc and base image for Go 1.19
Why are these changes needed?
Please see issue#1329
Update Development.md and Dockerfile for Go 1.19
Related issue number
Closes #1329
Checks
How to verify
Run the following and make sure no errors from the make commands.
/cc @kevin85421 @anishasthana