Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CLI to kuberay #135

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Add CLI to kuberay #135

merged 1 commit into from
Jan 27, 2022

Conversation

wolfsniper2388
Copy link
Contributor

Why are these changes needed?

Add CLI support for kuberay

Related issue number

#134

TODO

  • Add README for more detailed usage.
  • Make it go gettable.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

Jeffwan
Jeffwan reviewed Jan 25, 2022
View reviewed changes
cli/LICENSE Outdated Show resolved Hide resolved
cli/cmd/root.go Outdated Show resolved Hide resolved
cli/go.mod Outdated Show resolved Hide resolved
cli/main.go Outdated Show resolved Hide resolved
cli/pkg/cmd/cluster/cluster.go Outdated Show resolved Hide resolved
cli/pkg/cmd/cluster/create.go Show resolved Hide resolved
cli/pkg/cmdutil/auth.go Outdated Show resolved Hide resolved
@Jeffwan
Copy link
Collaborator

Jeffwan commented Jan 25, 2022

@wolfsniper2388 Great work! there're two more things needs to be done.

  1. Please help update .github/workflows file to include cli into CI builds. or you can file it as a separate PR with [Feature] Setup CI for new submodules #117

  2. Please help write a README.md under the cli folder and share usage with users.

@wolfsniper2388 wolfsniper2388 force-pushed the topic/wolfsniper2388/cli branch 2 times, most recently from d602d15 to 8d79a30 Compare January 26, 2022 04:31
Jeffwan
Jeffwan approved these changes Jan 26, 2022
View reviewed changes
Copy link
Collaborator

@Jeffwan Jeffwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This revision looks good to me.

@Jeffwan Jeffwan merged commit 3cd3009 into ray-project:master Jan 27, 2022
lowang-bh pushed a commit to lowang-bh/kuberay that referenced this pull request Sep 24, 2023
@wolfsniper2388
Add CLI to kuberay (ray-project#135)
ccad8b4 
Co-authored-by: Yifei Feng <[email protected]>
@gvspraveen gvspraveen mentioned this pull request Jan 3, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeffwan Jeffwan Jeffwan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wolfsniper2388 @Jeffwan